optoe: Add CMIS Bank support for transceivers with >8 lanes#473
Open
ishidawataru wants to merge 8 commits intosonic-net:masterfrom
Open
optoe: Add CMIS Bank support for transceivers with >8 lanes#473ishidawataru wants to merge 8 commits intosonic-net:masterfrom
ishidawataru wants to merge 8 commits intosonic-net:masterfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds CMIS Bank support to the 'optoe3' device class in order
to enable access to CMIS transceivers with more than 8 lanes (e.g., OSFP-XD, CPO OEs).
The default bank size is set to 4, and can be modified via the 'bank_size' sysfs entry.For 'optoe3', the 'write_max' value is updated to 2 to comply with CMIS requirements,which mandate that both bank and page values be updated in a single WRITE operation.
Updated the behavior as below after discussing with @prgeor offline
automatically updated to 2 to comply with CMIS requirements,
which mandate that both bank and page values be updated in a single WRITE operation.
Only tested with the SONiC VM + i2c-stub.
Snip of dmesg. See bank:3 is accessed.
Not tested with real hardware yet.