Disable SPD instantiation in I2C SMBUS driver#542
Disable SPD instantiation in I2C SMBUS driver#542aravindmani-1 wants to merge 4 commits intosonic-net:masterfrom
Conversation
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
aravindmani-1
force-pushed
the
i2c_smbus_newflag
branch
from
944c87e to
59264b7
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: aravindmani-1 <aravind_m1@dell.com>
Signed-off-by: aravindmani-1 <aravind_m1@dell.com>
Signed-off-by: aravindmani-1 <aravind_m1@dell.com>
| From: Aravind Mani <aravind.m1@dell.com> | ||
| Date: Mon, 3 Mar 2026 00:00:00 +0000 | ||
| Subject: [PATCH] i2c: smbus: Add disable_spd module parameter to skip | ||
| automatic SPD EEPROM instantiation |
There was a problem hiding this comment.
Please do not break the commit title.
There was a problem hiding this comment.
Thanks. Addressed now.
| Usage: | ||
| modprobe i2c-smbus disable_spd=1 | ||
| or: echo "options i2c-smbus disable_spd=1" > /etc/modprobe.d/i2c-smbus.conf | ||
|
|
There was a problem hiding this comment.
Thank you for the great commit message. Did you send it upstream for review, so we do not have to carry this forever.
There was a problem hiding this comment.
We have sent the patch to Linux community for review.
There was a problem hiding this comment.
URL:
https://lkml.org/lkml/2026/3/11/782
Please note that we have sent the recently only to linux community and waiting for review.
There was a problem hiding this comment.
Awesome. Thank you for working upstream. From a cursory look, I noted some formal errors. You should use git send-email to properly send the patch, send it also directly to the maintainers ./scripts/get_maintainer.pl <your patch file> and use 75 characters per line for the commit message scripts/checkpatch.pl <your patch file> (I think). Feel free to Cc me on the patch iteration (git format-patch -v 2).
aravindmani-1
force-pushed
the
i2c_smbus_newflag
branch
from
d82c2c0 to
5fb52a2
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: aravindmani-1 <aravind_m1@dell.com>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
4 participants
Summary:
In some of the Dell switch platforms(Z9864F,Z9964F), the system EEPROM resides at address 0x50 on the DDR SMBUS.
The automatic SPD scanning grabs this address with the ee1004 driver before the platform driver can claim it with the at24 driver and it breaks system EEPROM access.
Added a module parameter 'disable_spd' (default 0) in i2c-smbus driver.
By default, it allows automatic SPD EEPROM instantiation.
When disable_spd flag is set to 1,then the automatic SPD EEPROM instantiation will be disabled.
Signed-off-by: Aravind Mani aravind.m1@dell.com