fix: resolve pre-existing Biome lint warnings in spicetifyWrapper.js#3776
fix: resolve pre-existing Biome lint warnings in spicetifyWrapper.js#3776tmchow wants to merge 1 commit intospicetify:mainfrom
Conversation
Add explicit radix parameter to Number.parseInt() call (line 426) and remove unused refreshCount destructured variable (line 2366). Both issues were pre-existing and flagged during PR spicetify#3773 review by coderabbitai. Neither was introduced by that PR. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe changes refine version number parsing in a Cosmos proxy handler by adding an explicit base-10 radix to Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Two pre-existing Biome lint warnings in
jsHelper/spicetifyWrapper.js, discovered during #3773 review:Number.parseInt(i)missing explicit radix parameter. Added, 10for base-10 parsing.refreshCountdestructured fromuseReducerbut never read. Changed to[, refresh]to discard the unused value.Both are mechanical fixes with no behavior change. The
refreshfunction from the same destructuring is still used on line 2367.This contribution was developed with AI assistance (Claude Code).
Summary by CodeRabbit
Bug Fixes
Refactor