feat: make protobuf dependency optional for telemetry#100
Merged
Conversation
nicklasl
requested review from
DennisPersson,
fabriziodemaria,
mfranberg,
nickybondarenko and
vahidlazio
as code owners
vahidlazio
approved these changes
Sep 22, 2025
nicklasl
force-pushed
the
proto-dep-fix
branch
from
194a0ee to
9304b1c
Compare
- Move protobuf to core dependencies (default installation includes telemetry) - Add graceful fallback when protobuf unavailable (telemetry auto-disabled) - Implement optional import pattern with enum fallbacks - Add requirements-minimal.txt for installations without protobuf - Update documentation with both installation options - Add CI test matrix for full and minimal installation scenarios - Maintain backward compatibility - telemetry enabled by default Benefits: - Default install includes full telemetry (better UX) - Minimal install option for constrained environments - Graceful degradation without breaking core functionality - Both scenarios tested in CI pipeline 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Remove requirements-minimal.txt file to avoid maintenance burden - Use inline dependencies in CI workflow for minimal installation testing - Dependencies now stay in sync with pyproject.toml automatically - No more manual tracking of transitive dependencies 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Add telemetry.py to exclusions for flake8 and mypy - Complex conditional imports cause linter conflicts - Functionality works correctly (all tests pass) - Pragmatic approach to avoid maintenance overhead 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
nicklasl
force-pushed
the
proto-dep-fix
branch
from
9304b1c to
1457f54
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Benefits: