Merged
Conversation
fabriziodemaria
requested review from
DennisPersson,
mfranberg,
nicklasl,
nickybondarenko and
vahidlazio
as code owners
Signed-off-by: Fabrizio Demaria <fabrizio.f.demaria@gmail.com>
fabriziodemaria
force-pushed
the
telemetry
branch
6 times, most recently
from
d612b86 to
4fef28a
Compare
fabriziodemaria
commented
May 5, 2025
fabriziodemaria
force-pushed
the
telemetry
branch
3 times, most recently
from
981f2d8 to
fa5312e
Compare
nicklasl
reviewed
May 6, 2025
Signed-off-by: Fabrizio Demaria <fabrizio.f.demaria@gmail.com>
fabriziodemaria
force-pushed
the
telemetry
branch
2 times, most recently
from
ed886e2 to
5c5dc60
Compare
Signed-off-by: Fabrizio Demaria <fabrizio.f.demaria@gmail.com>
fabriziodemaria
force-pushed
the
telemetry
branch
3 times, most recently
from
948bb7d to
5f757ca
Compare
Signed-off-by: Fabrizio Demaria <fabrizio.f.demaria@gmail.com>
Signed-off-by: Fabrizio Demaria <fabrizio.f.demaria@gmail.com>
Signed-off-by: Fabrizio Demaria <fabrizio.f.demaria@gmail.com>
fabriziodemaria
force-pushed
the
telemetry
branch
2 times, most recently
from
1f000a8 to
4853f4b
Compare
Signed-off-by: Fabrizio Demaria <fabrizio.f.demaria@gmail.com>
nicklasl
reviewed
May 7, 2025
| @@ -0,0 +1,53 @@ | |||
| # -*- coding: utf-8 -*- | |||
| # Generated by the protocol buffer compiler. DO NOT EDIT! | |||
| # NO CHECKED-IN PROTOBUF GENCODE | |||
Member
There was a problem hiding this comment.
In general I don't really oppose this being checked in (for an SDK) but is there pros and cons (and can we even setup something to generate it on build)?
Member
Author
There was a problem hiding this comment.
Not sure about this detail. I would prefer the plug-and-play experience from the checked-in code, also considering it's not too big
Co-authored-by: Nicklas Lundin <nicklasl@spotify.com>
nicklasl
approved these changes
May 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding Telemetry, a upcoming functionality from Confidence.
Telemetry is a functionality designed to send data about the functioning and performance of the SDK to the Confidence backend, with minimal impact on the SDK performance itself.
Notes on the PR: