fix: replace hard-coded JWKS timeouts#18563
Open
knoobie wants to merge 1 commit intospring-projects:mainfrom
Open
fix: replace hard-coded JWKS timeouts#18563knoobie wants to merge 1 commit intospring-projects:mainfrom
knoobie wants to merge 1 commit intospring-projects:mainfrom
Conversation
Replace the hard-coded 500ms connect- and read-timeouts for the jwks request to use the recommended method that evaluates the system property to lower or increase the timeouts. Signed-off-by: Knoobie <Knoobie@gmx.de>
knoobie
changed the title
spring-projects-issues
added
the
status: waiting-for-triage
jzheaux
reviewed
Feb 26, 2026
| SimpleClientHttpRequestFactory requestFactory = new SimpleClientHttpRequestFactory(); | ||
| requestFactory.setConnectTimeout(JWKSourceBuilder.DEFAULT_HTTP_CONNECT_TIMEOUT); | ||
| requestFactory.setReadTimeout(JWKSourceBuilder.DEFAULT_HTTP_READ_TIMEOUT); | ||
| requestFactory.setConnectTimeout(RemoteJWKSet.resolveDefaultHTTPConnectTimeout()); |
Contributor
There was a problem hiding this comment.
I'd prefer to not go from a non-deprecated to a deprecated API. I've added https://bitbucket.org/connect2id/nimbus-jose-jwt/issues/614 to see what the recommended approach is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the hard-coded 500ms connect- and read-timeouts for the jwks request to use the recommended method that evaluates the system property to lower or increase the timeouts.