Add a configurable ServerAuthenticationSuccessHandler to OAuth2Resour…#18895
Open
iain-henderson wants to merge 1 commit intospring-projects:mainfrom
Open
Conversation
spring-projects-issues
added
the
status: waiting-for-triage
jzheaux
requested changes
Mar 20, 2026
Contributor
jzheaux
left a comment
jzheaux
left a comment
There was a problem hiding this comment.
Thanks, @iain-henderson! I've left some feedback inline. Will you also please add a unit test to OAuth2ResourceServerSpecTests to confirm the authenticationSuccessHandler is used when specified?
| return this; | ||
| } | ||
|
|
||
| public OAuth2ResourceServerSpec authenticationSuccessHandler( |
Contributor
There was a problem hiding this comment.
Will you please add a JavaDoc here, please? Please include a description of the method, what the default value is, and a @since 7.1 indicating the version in which it was added.
Contributor
|
In addition to the review comments, will you please make sure to sign the DCO? |
jzheaux
added
in: config
jzheaux
added
the
status: waiting-for-feedback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The lack of a configurable ServerAuthenticationSuccessHandler in OAuth2ResourceServerSpec seemed like an oversight.
This PR corrects that.