Fix handling of missing access token during refresh token invalidation#18964
Closed
itsmevichu wants to merge 1 commit intospring-projects:mainfrom
Closed
Fix handling of missing access token during refresh token invalidation#18964itsmevichu wants to merge 1 commit intospring-projects:mainfrom
itsmevichu wants to merge 1 commit intospring-projects:mainfrom
Conversation
Signed-off-by: Vishnutheep B <vishnutheep@gmail.com>
spring-projects-issues
added
the
status: waiting-for-triage
Contributor
|
Closing as per comment. In the future, please hold off on submitting a fix until the team has determined a fix is needed. Thanks. |
jgrandja
added
status: declined
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18935
This change adds a null check when invalidating the access token in
OAuth2Authorization.Builder.invalidate().This is necessary because the builder allows independent configuration of tokens, making it valid to construct an OAuth2Authorization where the access token is absent. The current implementation assumes its presence and can throw a NullPointerException during refresh token revocation.