Complete nullability annotations in remaining equals methods#19016
Open
therepanic wants to merge 1 commit intospring-projects:mainfrom
Open
Conversation
Contributor
Author
|
This PR is a follow-up to: #18930 BTW, the build crashes not because of the current changes https://github.com/spring-projects/spring-security/actions/runs/23822120186/job/69436701182/ |
therepanic
commented
Apr 1, 2026
Comment on lines
139
to
141
| @Override | ||
| public boolean equals(Object obj) { | ||
| public boolean equals(@Nullable Object obj) { | ||
| if (this == obj) { |
Contributor
Author
There was a problem hiding this comment.
This module had jspecify support before, I guess I accidentally missed it.
spring-projects-issues
added
the
status: waiting-for-triage
In this commit, we'll finally add nullability annotations to the equals method for consistency with other projects. We've already done this, but we recently added jspecify support to new modules. Signed-off-by: Andrey Litvitski <andrey1010102008@gmail.com>
therepanic
force-pushed
the
complete-nullability-annotations-in-remaining-equals-methods
branch
from
d2c4481 to
d656397
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this commit, we'll finally add nullability annotations to the equals method for consistency with other projects. We've already done this, but we recently added jspecify support to new modules.