Deprecate Hex in favor of java.util.HexFormat#19023
Open
therepanic wants to merge 1 commit intospring-projects:mainfrom
Open
Deprecate Hex in favor of java.util.HexFormat#19023therepanic wants to merge 1 commit intospring-projects:mainfrom
java.util.HexFormat#19023therepanic wants to merge 1 commit intospring-projects:mainfrom
Conversation
The main point is that java.util.HexFormat essentially does the same thing as our Hex. We had a similar candidate with Base and deprecated it in favor of java.util.Base64. Moreover, we've already removed it: 2f53a2e. Closes: spring-projectsgh-16867 Signed-off-by: Andrey Litvitski <andrey1010102008@gmail.com>
spring-projects-issues
added
the
status: waiting-for-triage
Contributor
Author
|
If we are satisfied with this, I can create an issue with a fix where we will replace all usage with the new Java 17 api. |
therepanic
changed the title
java.util.HexFormat
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main point is that java.util.HexFormat essentially does the same thing as our Hex. We had a similar candidate with Base and deprecated it in favor of java.util.Base64. Moreover, we've already removed it: therepanic@2f53a2e.
Closes: gh-16867