feat: Add end-to-end test and compiler support for SQLite boolean arguments with the NOT operator.#4327
Open
noxymon wants to merge 1 commit intosqlc-dev:mainfrom
Open
feat: Add end-to-end test and compiler support for SQLite boolean arguments with the NOT operator.#4327noxymon wants to merge 1 commit intosqlc-dev:mainfrom
noxymon wants to merge 1 commit intosqlc-dev:mainfrom
Conversation
…uments with the NOT operator.
dosubot
bot
added
size:M
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
The goal was to resolve Issue #4305 where the NOT keyword breaks boolean argument detection for SQLite.
Cause of the Bug
When an expression like
not @argnameis parsed bycznic/sqlite, it produces an AST node which SQLC converts into an*ast.BoolExpr. During type inference, the compiler loops over the AST nodes wrapping parameters (insideinternal/compiler/resolve.go) to infer their basic types (e.g. limitOffset -> integer).However,
internal/compiler/resolve.gowas completely missing a case
*ast.BoolExpr:!Because of this, it fell back to generating anUnknownParam, which resulted in the typeinterface{}(orany) instead ofbool/boolean.The Fix
internal/compiler/resolve.goto intercept*ast.BoolExprparameter bindings.boolean, ensuring SQLC correctly infers arguments wrapped in NOT, AND or OR as boolean inputs in Go output.