feat(stackable-versioned)!: Automatically generate conversion roundtrip tests#1172
Open
feat(stackable-versioned)!: Automatically generate conversion roundtrip tests#1172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This was originally implemented back in #1050, but was removed to keep things simpler.
As I spiked a CRD conversion in secret-operator I wondered if my implementation was actually roundtrip-safe. So I remembered this follow-up task and re-added the testing infrastructure. Now the compiler will force me to find out if it is roundtrip-safe 🚀
The PR adds some testdata for all stackable-operator structs. It unsurprisingly uncovered the missing roundtrip-ability of the
Persontest-struct, as it changes a field, while so far only field additions are supported by the conversion tracking. I hope we don't have a CRD conversion that fails roundtrips in production yet :) This PR is here to prevent exactly that.Definition of Done Checklist
Author
Reviewer
Acceptance