Skip to content

Comments

Suppress update message if is trigger by desktop#3885

Open
samuv wants to merge 3 commits intomainfrom
skip-update
Open

Suppress update message if is trigger by desktop#3885
samuv wants to merge 3 commits intomainfrom
skip-update

Conversation

@samuv
Copy link
Contributor

@samuv samuv commented Feb 18, 2026

When the thv is bundled with the Desktop app, we don’t need to show the upgrade message because it’s handled by the app’s release cycle.

@github-actions github-actions bot added the size/S Small PR: 100-299 lines changed label Feb 18, 2026
@codecov
Copy link

codecov bot commented Feb 18, 2026

Codecov Report

❌ Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.22%. Comparing base (8075728) to head (ee7f859).

Files with missing lines Patch % Lines
pkg/desktop/validation.go 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3885      +/-   ##
==========================================
+ Coverage   67.17%   67.22%   +0.04%     
==========================================
  Files         449      449              
  Lines       45271    45278       +7     
==========================================
+ Hits        30413    30439      +26     
+ Misses      12492    12467      -25     
- Partials     2366     2372       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions github-actions bot added size/S Small PR: 100-299 lines changed and removed size/S Small PR: 100-299 lines changed labels Feb 18, 2026
@github-actions github-actions bot added size/S Small PR: 100-299 lines changed and removed size/S Small PR: 100-299 lines changed labels Feb 19, 2026
@eleftherias
Copy link
Member

Because we bundle the update check with metrics, I wonder if this would cause us to lose CLI usage metrics. @lujunsan Could you take a look?

Copy link
Contributor

@lujunsan lujunsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the heads up @eleftherias .

@samuv added a comment, as what Ria pointed out is correct.

@samuv
Copy link
Contributor Author

samuv commented Feb 20, 2026

thanks @eleftherias and @lujunsan. I’m moving the check to where the message-printing logic lives, as suggested, so we can leave the rest untouched

@github-actions github-actions bot added size/S Small PR: 100-299 lines changed and removed size/S Small PR: 100-299 lines changed labels Feb 20, 2026
@github-actions github-actions bot added size/S Small PR: 100-299 lines changed and removed size/S Small PR: 100-299 lines changed labels Feb 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/S Small PR: 100-299 lines changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants