Skip to content

Comments

Hide already registered clients in thv client setup#3889

Open
carlos-gn wants to merge 3 commits intostacklok:mainfrom
carlos-gn:feat/hide-registered-clients-in-setup
Open

Hide already registered clients in thv client setup#3889
carlos-gn wants to merge 3 commits intostacklok:mainfrom
carlos-gn:feat/hide-registered-clients-in-setup

Conversation

@carlos-gn
Copy link
Contributor

Summary

  • Filters out clients that are already registered in all selected groups from the client selection step in thv client setup
  • When all installed clients are already registered for the selected groups, exits early with a clear message
  • Handles both interactive group selection (multiple groups) and auto-selected groups (single group)

Closes #1308

Test plan

  • Unit tests for FilterClientsAlreadyRegistered covering all edge cases
  • Unit tests for setupModel.Update verifying group-to-client transition filtering
  • Unit tests for client selection toggle and confirmation behavior
  • Manual testing: verify clients already registered in all selected groups are hidden
  • Manual testing: verify clients registered in only some groups still appear
  • Manual testing: verify "all clients registered" message when no clients remain

🤖 Generated with Claude Code

@github-actions github-actions bot added the size/M Medium PR: 300-599 lines changed label Feb 18, 2026
When selecting clients in `thv client setup`, clients that are already
registered for all selected groups are now filtered out of the selection
list. If all installed clients are already registered, the command exits
with a clear message instead of showing an empty list.

Closes stacklok#1308

Signed-off-by: carlos <21148423+carlos-gn@users.noreply.github.com>
@carlos-gn carlos-gn force-pushed the feat/hide-registered-clients-in-setup branch from 8931db6 to fea2308 Compare February 18, 2026 20:50
@github-actions github-actions bot added size/M Medium PR: 300-599 lines changed and removed size/M Medium PR: 300-599 lines changed labels Feb 18, 2026
@codecov
Copy link

codecov bot commented Feb 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.20%. Comparing base (65f28eb) to head (4ece54a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3889      +/-   ##
==========================================
+ Coverage   67.18%   67.20%   +0.02%     
==========================================
  Files         448      449       +1     
  Lines       45218    45236      +18     
==========================================
+ Hits        30380    30402      +22     
+ Misses      12469    12462       -7     
- Partials     2369     2372       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions github-actions bot added size/M Medium PR: 300-599 lines changed and removed size/M Medium PR: 300-599 lines changed labels Feb 20, 2026
@github-actions github-actions bot added size/M Medium PR: 300-599 lines changed and removed size/M Medium PR: 300-599 lines changed labels Feb 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/M Medium PR: 300-599 lines changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hide already registered clients in thv client setup command

1 participant