Skip to content

chore: fix JavaScript lint errors (issue #10184)#10724

Open
travisbreaks wants to merge 1 commit intostdlib-js:developfrom
travisbreaks:fix/issue-10184
Open

chore: fix JavaScript lint errors (issue #10184)#10724
travisbreaks wants to merge 1 commit intostdlib-js:developfrom
travisbreaks:fix/issue-10184

Conversation

@travisbreaks
Copy link
Contributor

@travisbreaks travisbreaks commented Mar 6, 2026

Description

Fixes the stdlib/no-new-array lint errors reported in issue #10184 by replacing new Array() constructor calls with array literals.

Changes

  • lib/node_modules/@stdlib/math/strided/special/ahavercos-by/test/test.main.js: Replace new Array( 5 ) sparse array construction with x = []; x.length = 5; pattern (2 occurrences). Remove associated eslint-disable-next-line directives.
  • lib/node_modules/@stdlib/assert/is-empty-collection/test/test.js: Replace new Array( 10 ) with an explicit array literal [ 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 ].

Related Issues

Resolves #10184


Co-authored-by: Egger egger@horny-toad.com

Checklist

- Replace `new Array( 5 )` with `x = []; x.length = 5;` for sparse arrays in ahavercos-by/test/test.main.js
- Replace `new Array( 10 )` with array literal in is-empty-collection/test/test.js
- Remove unnecessary eslint-disable-next-line directives

Co-authored-by: Egger <egger@horny-toad.com>
@stdlib-bot
Copy link
Contributor

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

Getting Started

Next Steps

  1. A project maintainer will approve GitHub Actions workflows for your PR.
  2. All CI checks must pass before your submission can be fully reviewed.
  3. You'll need to address any failures in linting or unit tests.

Running Tests Locally

You can use make to run any of the CI commands locally from the root directory of the stdlib repository:

# Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"

# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"

If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR.

If you have any further questions while waiting for a response, please join our Zulip community to chat with project maintainers and other community members.

We appreciate your contribution!

Documentation Links

@stdlib-bot stdlib-bot added First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. labels Mar 6, 2026
@stdlib-bot
Copy link
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

@stdlib-bot stdlib-bot added Good First PR A pull request resolving a Good First Issue. and removed First-time Contributor A pull request from a contributor who has never previously committed to the project repository. labels Mar 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Good First PR A pull request resolving a Good First Issue. Needs Review A pull request which needs code review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix JavaScript lint errors

2 participants