Skip to content

chore: fix JavaScript lint errors (issue #10708)#10725

Open
travisbreaks wants to merge 1 commit intostdlib-js:developfrom
travisbreaks:fix/issue-10708
Open

chore: fix JavaScript lint errors (issue #10708)#10725
travisbreaks wants to merge 1 commit intostdlib-js:developfrom
travisbreaks:fix/issue-10708

Conversation

@travisbreaks
Copy link
Contributor

@travisbreaks travisbreaks commented Mar 6, 2026

Description

Fixes the stdlib/no-new-array lint error reported in issue #10708 by replacing the new Array() constructor with an array literal.

Changes

  • lib/node_modules/@stdlib/ndarray/fancy/test/test.instance.tostring.js (line 178): Replace new Array( 1e4 ) with buffer = []; buffer.length = 1e4; to create a sparse array without using the Array constructor.

Related Issues

Resolves #10708


Co-authored-by: Egger egger@horny-toad.com

Checklist

Replace `new Array( 1e4 )` with `buffer = []; buffer.length = 1e4;` to satisfy the stdlib/no-new-array lint rule in ndarray/fancy/test/test.instance.tostring.js.

Co-authored-by: Egger <egger@horny-toad.com>
@stdlib-bot stdlib-bot added First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue. Needs Review A pull request which needs code review. labels Mar 6, 2026
@stdlib-bot
Copy link
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

@stdlib-bot stdlib-bot added the Potential Duplicate There might be another pull request resolving the same issue. label Mar 6, 2026
@stdlib-bot stdlib-bot removed the First-time Contributor A pull request from a contributor who has never previously committed to the project repository. label Mar 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Good First PR A pull request resolving a Good First Issue. Needs Review A pull request which needs code review. Potential Duplicate There might be another pull request resolving the same issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix JavaScript lint errors

2 participants