chore: fix JavaScript lint errors (issue #10528)#10726
Open
travisbreaks wants to merge 1 commit intostdlib-js:developfrom
Open
chore: fix JavaScript lint errors (issue #10528)#10726travisbreaks wants to merge 1 commit intostdlib-js:developfrom
travisbreaks wants to merge 1 commit intostdlib-js:developfrom
Conversation
- Fix array-element-newline errors in stats/kstest/test/test.marsaglia.js by adding linebreaks between array elements - Remove unused eslint-disable directives for array-element-newline - Replace new Array() constructor with array literals and push in utils/pluck/benchmark/benchmark.js Co-authored-by: Egger <egger@horny-toad.com>
Contributor
|
Hello! Thank you for your contribution to stdlib. We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:
This acknowledgment confirms that you've read the guidelines, which include:
We can't review or accept contributions without this acknowledgment. Thank you for your understanding and cooperation. We look forward to reviewing your contribution! |
stdlib-bot
added
First-time Contributor
7 tasks
stdlib-bot
removed
the
First-time Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the JavaScript lint errors reported in issue #10528.
Changes
lib/node_modules/@stdlib/stats/kstest/test/test.marsaglia.js:eslint-disable-line array-element-newlinedirectives on lines 46-47array-element-newlineerrors in theexpectedarray by placing each element on its own linelib/node_modules/@stdlib/utils/pluck/benchmark/benchmark.js:new Array( 100 )andnew Array( 5 )constructors with array literals andpush()to satisfy thestdlib/no-new-arraylint ruleRelated Issues
Resolves #10528
Co-authored-by: Egger egger@horny-toad.com
Checklist