feat: add C implementation for @stdlib/stats/base/dists/lognormal/logpdf#10881
Open
rautelaKamal wants to merge 3 commits intostdlib-js:developfrom
Open
feat: add C implementation for @stdlib/stats/base/dists/lognormal/logpdf#10881rautelaKamal wants to merge 3 commits intostdlib-js:developfrom
rautelaKamal wants to merge 3 commits intostdlib-js:developfrom
Conversation
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
- Add standalone C implementation using ln, pow, PI constants - Add native.js binding, header, addon.c, Makefile, binding.gyp - Add test.native.js, benchmark.native.js with variable sorting - Add benchmark.js with len variable to fix max-len eslint rule - Update package.json and manifest.json Signed-off-by: Kamal Singh Rautela <e22cseu1624@bennett.edu.in>
6f8590a to
da83153
Compare
Signed-off-by: Kamal Singh Rautela <e22cseu1624@bennett.edu.in>
Signed-off-by: Kamal Singh Rautela <e22cseu1624@bennett.edu.in>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
What is the purpose of this pull request?
This pull request:
@stdlib/stats/base/dists/lognormal/logpdf), and includes the corresponding native N-API bindings following theDDD_Dpattern found in similar modules likearcsine/logpdf.Related Issues
Does this pull request have any related issues?
This pull request has the following related issues:
Questions
Any questions for reviewers of this pull request?
No.
Other
Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.
AI Assistance Disclosure
If yes, how was AI used?
I used an AI assistant to help stub out the initial C boilerplate (header files, build configurations) and to mirror the JS test suite into native tests, which I then carefully reviewed and validated against stdlib guidelines before submitting.
Checklist