feat(utils/async/any-by): add instrumentation to measure async operation duration#10910
Closed
MANDEep22332 wants to merge 2 commits intostdlib-js:developfrom
Closed
feat(utils/async/any-by): add instrumentation to measure async operation duration#10910MANDEep22332 wants to merge 2 commits intostdlib-js:developfrom
MANDEep22332 wants to merge 2 commits intostdlib-js:developfrom
Conversation
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown
status: na
- task: lint_package_json
status: na
- task: lint_repl_help
status: na
- task: lint_javascript_src
status: na
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: na
- task: lint_javascript_tests
status: na
- task: lint_javascript_benchmarks
status: passed
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: na
- task: lint_c_examples
status: na
- task: lint_c_benchmarks
status: na
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: passed
- task: lint_typescript_tests
status: na
- task: lint_license_headers
status: passed
---
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown
status: na
- task: lint_package_json
status: na
- task: lint_repl_help
status: na
- task: lint_javascript_src
status: passed
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: na
- task: lint_javascript_tests
status: passed
- task: lint_javascript_benchmarks
status: na
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: na
- task: lint_c_examples
status: na
- task: lint_c_benchmarks
status: na
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: passed
- task: lint_typescript_tests
status: na
- task: lint_license_headers
status: passed
---
kgryte
reviewed
Mar 13, 2026
Member
There was a problem hiding this comment.
This change is unrelated to this PR.
Member
|
@MANDEep22332 This PR is not what we are looking for in terms of instrumentation. See the upstream RFC in the GSoC repo: stdlib-js/google-summer-of-code#9. As such, I am going to go ahead and close this PR. Thank you for your interest, and we look forward to your future contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #5808
Description
This pull request:
instrument.js) to theanyByAsyncutility tomeasure the duration of async operations. The timer starts when
anyByAsyncis invoked and stops when the
donecallback is called, returning elapsedtime in milliseconds. }}
##changes
internal/instrument.js: new file — creates a high-resolution timer usingprocess.hrtime()and returns elapsed time in millisecondslib/factory.js: integratecreateTimerintoanyByAsync; duration ispassed as a third argument to the
donecallbacktest/test.instrument.js: unit tests for thecreateTimerfunctionRelated Issues
This pull request has the following related issues:
Questions
No.
Other
done( error, bool, duration )rather than logged, keeping the utility side-effect free
anyByAsync.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
{{TODO: add disclosure if applicable}}
@stdlib-js/reviewers