-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
feat: add stats/base/dists/halfnormal/stdev
#9714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add stats/base/dists/halfnormal/stdev
#9714
Conversation
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown
status: passed
- task: lint_package_json
status: passed
- task: lint_repl_help
status: passed
- task: lint_javascript_src
status: passed
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: passed
- task: lint_javascript_tests
status: passed
- task: lint_javascript_benchmarks
status: passed
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: missing_dependencies
- task: lint_c_examples
status: missing_dependencies
- task: lint_c_benchmarks
status: missing_dependencies
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: passed
- task: lint_typescript_tests
status: passed
- task: lint_license_headers
status: passed
---
stats/base/dists/halfnormal/stdev
Planeshifter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
| var opts = { | ||
| 'dtype': 'float64' | ||
| }; | ||
| var sigma = uniform( 10, 0.0, 20.0, opts ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The README example uses 0.1 as the minimum value, but this file uses 0.0. To keep consistency with the README,
| var sigma = uniform( 10, 0.0, 20.0, opts ); | |
| var sigma = uniform( 10, 0.1, 20.0, opts ); |
| }, # end target copy_addon | ||
| ], # end targets | ||
| } | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file has two trailing newlines. Per stdlib style, files should end with exactly one trailing newline.
| ], | ||
| }, # end variables | ||
| } | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file has two trailing newlines. Per stdlib style, files should end with exactly one trailing newline.
| } | ||
| ] | ||
| } | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file has two trailing newlines. Per stdlib style, files should end with exactly one trailing newline.
|
See also failing check runs. |
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown
status: passed
- task: lint_package_json
status: na
- task: lint_repl_help
status: na
- task: lint_javascript_src
status: passed
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: passed
- task: lint_javascript_tests
status: passed
- task: lint_javascript_benchmarks
status: passed
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: missing_dependencies
- task: lint_c_examples
status: missing_dependencies
- task: lint_c_benchmarks
status: missing_dependencies
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: passed
- task: lint_typescript_tests
status: passed
- task: lint_license_headers
status: passed
---
Coverage Report
The above coverage report was generated for the changes in this PR. |
lib/node_modules/@stdlib/stats/base/dists/halfnormal/stdev/src/main.c
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/dists/halfnormal/stdev/docs/types/test.ts
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/dists/halfnormal/stdev/lib/index.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/dists/halfnormal/stdev/lib/main.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/dists/halfnormal/stdev/lib/native.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Philipp Burckhardt <[email protected]>
Planeshifter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's get it in! 🚀
PR Commit MessagePlease review the above commit message and make any necessary adjustments. |
|
@bhargava-d16 How did you generate fixture data for this PR? It doesn't appear that the There is a PR adding support for folded distributions, but that has not been merged. Ref: JuliaStats/Distributions.jl#1631 |
|
Thanks for pointing this out. You are right that HalfNormal is not currently part of the released Distributions.jl. The fixture values were generated using the analytical expression for the standard deviation of the Half-Normal distribution, not a built-in Julia distribution. Specifically, for a Half-Normal distribution with scale sigma, the standard deviation is: The current Julia fixture script is therefore misleading, as it suggests use of Distributions.HalfNormal. Please let me know if I need to update the script to compute the standard deviation directly from the formula and I’ll make the requested changes. |
|
@bhargava-d16 Instead of Julia, you can generate fixtures from SciPy. See https://github.com/stdlib-js/stdlib/tree/develop/tools/snippets/test/fixtures for snippets which can be used accordingly. I suggest making a follow-up PR. |
|
Thanks for the suggestion! |
|
I’ve opened a follow-up PR as suggested: #9784 |
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:
Progresses #9416
Description
This pull request:
Related Issues
This pull request has the following related issues:
@stdlib/stats/base/dists/halfnormalpackage #9416Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
I consulted ChatGPT to verify mathematical formulation of half-normal standard deviation function and to confirm expected numerical values
@stdlib-js/reviewers