Skip to content

Conversation

@SuYaSh-PaThAk04
Copy link
Contributor

Resolves - #9825

Description

What is the purpose of this pull request?

This pull request:

  • Fixes a JavaScript lint error caused by an unnecessary nested function in the
    remark-stdlib-urls-www transformer.
  • Moves visitor to outer scope via a factory function
  • No functional changes

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

{{TODO: add disclosure if applicable}}


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Tools Issue or pull request related to project tooling. Good First PR A pull request resolving a Good First Issue. Needs Review A pull request which needs code review. labels Jan 19, 2026
@Planeshifter
Copy link
Member

Planeshifter commented Jan 20, 2026

Resolved via #9829 instead. Moving one level up only instead of module scope allows us to avoid having to declare a wrapper function. Thanks for opening PR!

@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Jan 20, 2026
@SuYaSh-PaThAk04 SuYaSh-PaThAk04 deleted the chore/fix-js-lint-9825 branch January 20, 2026 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Good First PR A pull request resolving a Good First Issue. Tools Issue or pull request related to project tooling.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants