Add reusable actions from Strimzi projects#1
Open
Frawless wants to merge 6 commits intostrimzi:mainfrom
Open
Conversation
Signed-off-by: Jakub Stejskal <xstejs24@gmail.com>
Signed-off-by: Jakub Stejskal <xstejs24@gmail.com>
Member
|
❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ |
scholzj
reviewed
Feb 9, 2026
Member
scholzj
left a comment
scholzj
left a comment
There was a problem hiding this comment.
I swear I tried to review it ... but it's pretty hard ... and I have the attention span of a goldfish ... but at least something 😮
.github/actions/build/build-binaries/strimzi-operator-uncommitted-changes.sh
Outdated
Show resolved
Hide resolved
Frawless
commented
Feb 9, 2026
im-konge
reviewed
Feb 9, 2026
Member
im-konge
left a comment
im-konge
left a comment
There was a problem hiding this comment.
Thanks for working on this, I left couple of comments.
im-konge
reviewed
Feb 10, 2026
Signed-off-by: Jakub Stejskal <xstejs24@gmail.com>
Member
Author
|
I did some changes after reviews and @im-konge gave it a try on https://github.com/strimzi/test-clients/actions/runs/21869370774/job/63119641600?pr=147 . The PR is ready for another round of reviews. |
im-konge
reviewed
Feb 11, 2026
Member
im-konge
left a comment
im-konge
left a comment
There was a problem hiding this comment.
Last few comments from my side, thanks :)
Signed-off-by: Jakub Stejskal <xstejs24@gmail.com>
Signed-off-by: Jakub Stejskal <xstejs24@gmail.com>
Frawless
force-pushed
the
extract-actions
branch
from
df8c5ac to
0d99f13
Compare
im-konge
approved these changes
Feb 12, 2026
Member
im-konge
left a comment
im-konge
left a comment
There was a problem hiding this comment.
LGTM, thanks :) this is great.
Signed-off-by: Jakub Stejskal <xstejs24@gmail.com>
scholzj
approved these changes
Feb 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extracts re-usable actions from other strimzi projects. Notable we are speaking about dependencies actions:
and build actions:
THe actions are tested in local workflow, where:
Examples of integration tests - https://github.com/Frawless/github-actions/actions/workflows/test-integrations.yml
Example of dependencies checks - https://github.com/Frawless/github-actions/actions/workflows/test-dependencies.yml