This repository was archived by the owner on Dec 3, 2024. It is now read-only.
Fix material switch padding on item_device_form layout#2106
Open
Divinelink wants to merge 1 commit intosyncthing:mainfrom
Open
Fix material switch padding on item_device_form layout#2106Divinelink wants to merge 1 commit intosyncthing:mainfrom
Divinelink wants to merge 1 commit intosyncthing:mainfrom
Conversation
Divinelink
force-pushed
the
fix/material-switch-style-padding
branch
from
71f1a0d to
07b22f8
Compare
Divinelink
force-pushed
the
fix/material-switch-style-padding
branch
from
07b22f8 to
d4bb9d9
Compare
Member
|
Thanks for contributing - it's on my radar (and looks good/unproblematic). Just other/unrelated (procedural) things going on at the moment, thus not merging right away. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request addresses the missing padding in the
item_device_form.xml, which caused the Material Switch to appear too close to the edge of the screen. To resolve this, I added the same padding used by the other Material Switch components through their style.Let me know if this works for you!
Changes
What changes are made in this PR
android:paddingEnd="@dimen/abc_action_bar_content_inset_material"onitem_device_form.xmllayoutScreenshots
In case of UI changes, add before and after screenshots