Open
Conversation
Member
|
It should probably also have CI coverage to prevent regressions in the future. Edit: I should've read #696 first :) |
4923ecd to
14088a7
Compare
Contributor
Author
14088a7 to
124f157
Compare
Signed-off-by: Michael Nahkies <michael@nahkies.co.nz>
124f157 to
ee90d0f
Compare
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Edit: repurposed to check fmt during CI
fmtjob to theandroidgithub actions workflowmake fmt-checkfailurestacked on #696 this change simply runs the newmake lintcommand to reformat the code.I wasn't sure how annoying to review this would be, and so figured there is a decent chance a maintainer might prefer to run themselves (essentially replacing this PR).