Improve download function

[ayufan]

• Allow to specify used filename
• Output all settings as a comment on top of gcode
• Unify download buttons

[teachingtechYT]

Hi Ayufan,
This looks worthwhile. Perhaps you can help me, is there any way to access your fork live for me to test it a bit more?
Google is nt being my friend here. Alternatively I can copy and paste your updated code over my local coipy and test it there but perhaps you know of a more efficient way?
Michael

[ayufan]

@teachingtechYT

You can see these changes being deployed alongside the Octoprint support: #345. The addition there uses those functions introduced here.

Test it here: https://ayufan-research.github.io/teachingtechYT.github.io/calibration.html.

[ayufan]

It appears that output generation is broken at least in this case:

    if(formName.name == "accelerationForm") {
        string += "\nBase feedrate: "+formName.feedrate.value+" mm/s\n\n";

[teachingtechYT]

THanks for your work on this, it is defintely a positive change. I found some niggles in testing, some due to me not not updating the settings output as you discovered, others with formatting of gcode and UI preference. When I have a quieter week I will copy your changes to my local files and work from there in tweaking.

[ayufan]

If you can describe what to improve. I can happily do it.

…

On Sat, 14 Aug 2021 at 01:38, teachingtechYT ***@***.***> wrote: THanks for your work on this, it is defintely a positive change. I found some niggles in testing, some due to me not not updating the settings output as you discovered, others with formatting of gcode and UI preference. When I have a quieter week I will copy your changes to my local files and work from there in tweaking. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#343 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AASOSQJWOUOCNGUICDPNWTTT4WUGFANCNFSM5BVY43IA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email> .

[ayufan]

@teachingtechYT Did you had a chance to look at this?