Use CancellationToken.None for cleanup in .NET cancellation example#4446
Open
donald-pinckney wants to merge 1 commit intomainfrom
Open
Use CancellationToken.None for cleanup in .NET cancellation example#4446donald-pinckney wants to merge 1 commit intomainfrom
donald-pinckney wants to merge 1 commit intomainfrom
Conversation
Creating an inert CancellationTokenSource just to get a non-cancelled token is misleading — CancellationToken.None is the idiomatic no-op. Also add a note explaining when a new detached CancellationTokenSource would actually be appropriate. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
📖 Docs PR preview links
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CancellationTokenSourcejust to get a non-cancelled token for the cleanup activity.CancellationToken.Noneis the idiomatic no-op for this case.CancellationToken.Noneis used, and when a new detachedCancellationTokenSourcewould actually be appropriate (e.g. if cleanup itself needs to be cancellable from a timeout or signal).Context
This was discovered during code review of the skill for .NET (which lifted the example from the docs).
🤖 Generated with Claude Code
┆Attachments: EDU-6217 Use CancellationToken.None for cleanup in .NET cancellation example