fix nexus-service-bean explicitConfig support#2789
Open
Conversation
Quinn-With-Two-Ns
approved these changes
Feb 18, 2026
Contributor
Quinn-With-Two-Ns
left a comment
There was a problem hiding this comment.
Note, this will require SDK team approval
Author
|
By the way, if you need to workaround this bug right now you can just autodiscover on the temporal:
connection:
# Connection settings
target: ${TEMPORAL_ADDRESS:localhost:7233}
# API Key for Temporal Cloud
api-key: ${TEMPORAL_API_KEY:}
start-workers: true
namespace: ${TEMPORAL_NAMESPACE:default}
workers:
- task-queue: processing
workflow-classes:
- com.acme.processing.workflows.OrderImpl
# nexus-service-beans:
# - processing-service
workers-auto-discovery:
packages: com.acme.processing.services
``` |
tconley1428
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is not possible to register Nexus services via explicit config today (
nexus-service-beans).Expected Behavior
@Serviceimplementations should be registered on a Temporal Worker without using AutoConfiguration (aka explicit configuration).The problem is, Nexus Spring registration is not fully tested.
This config fails in
ExplicitConfigTestActual Behavior
When bringing up a worker doing explicit config only (spring), the
@ServiceImplattribute is not found while registering the service even when the attribute is present and correct.Steps to Reproduce the Problem
nexus-service-beans.The problem is we are using AopUtils to unpack the bean before getting the @serviceImpl definition but that is passing the class, not the implementation.
The fix is to just pass the bean in directly and tests pass.
Specifications
stack.txt
See tests