Add maven metadata and signature on workflowcheck aritfacts#2793
Merged
Add maven metadata and signature on workflowcheck aritfacts#2793
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the Gradle publishing setup so POM metadata and signing apply consistently to all Maven publications (including custom ones like the shadow publication), and ensures the temporal-workflowcheck shaded (“-all”) artifact meets Sonatype requirements.
Changes:
- Apply POM customization to every
MavenPublicationin each subproject (not justmavenJava). - Sign every
MavenPublicationwhen signing is configured. - Attach
sourcesJarandjavadocJarartifacts to theworkflowcheckshadow publication.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
temporal-workflowcheck/build.gradle |
Adds sources/javadoc artifacts to the shadow Maven publication for Sonatype validation. |
gradle/publishing.gradle |
Generalizes POM configuration and signing from mavenJava to all MavenPublication instances. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cretz
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
subprojects.publishing.publicationsconfig so it applies to everyMavenPublicationobject, not only themavenJavatarget. This allows subprojects to register extra publication targets that also inherit the POM and artifact signature configuration.workflowcheckshadow (-all) publication, added the required sources and javadoc artifacts.Why
workflowcheckmodule.