Skip to content

Comments

Make workflowcheck -all jar a variant of the main artifact#2794

Merged
mjameswh merged 4 commits intomasterfrom
workflowcheck-all-same-artifact-id
Feb 20, 2026
Merged

Make workflowcheck -all jar a variant of the main artifact#2794
mjameswh merged 4 commits intomasterfrom
workflowcheck-all-same-artifact-id

Conversation

@mjameswh
Copy link
Contributor

What changed?

  • The temporal-workflowcheck's shaded/fat JAR is now published as the all classifier on the main temporal-workflowcheck artifact, instead of a separate temporal-workflowcheck-all artifact.
  • User facing documentation and samples for the temporal-workflowcheck module have been updated to reflect the fact that this tool is now available from the Maven central repository (i.e. no longer mention “no published releases”).

Why?

  • Single artifact ID for both library and all-in-one JAR simplifies consumption and matches common Maven/Gradle practice (main jar + classified “fat” jar).
  • The previous shading configuration was causing errors when publishing release to Maven Central.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request refactors the publishing configuration for the temporal-workflowcheck module to publish the shaded/fat JAR as a classified variant (all classifier) of the main artifact instead of as a separate artifact (temporal-workflowcheck-all). The change aims to simplify consumption and align with common Maven/Gradle practices. Additionally, all user-facing documentation and samples have been updated to reflect that the tool is now available from Maven Central.

Changes:

  • Modified temporal-workflowcheck/build.gradle to remove custom shadow publication configuration and update shadow plugin version from 8.3.3 to 9.3.1
  • Updated Maven sample to use version 1.33.0 with all classifier instead of 1.0-SNAPSHOT
  • Updated Gradle samples to use :all classifier and removed composite build references
  • Fixed grammar in README ("is a utility scans" → "is a utility that scans") and added dependency examples with classifier syntax

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
temporal-workflowcheck/build.gradle Removed custom shadow publication config, removed archiveClassifier override, upgraded shadow plugin to 9.3.1
temporal-workflowcheck/README.md Fixed grammar, added dependency examples with all classifier, removed references to unpublished releases
temporal-workflowcheck/samples/maven/pom.xml Updated dependency to use version 1.33.0 with all classifier
temporal-workflowcheck/samples/maven/README.md Removed references to local repository setup and unpublished releases
temporal-workflowcheck/samples/gradle/settings.gradle Removed composite build inclusion to reflect Maven Central availability
temporal-workflowcheck/samples/gradle/build.gradle Added buildOnly dependency (invalid config) and updated workflowcheckDependency to use :all classifier
temporal-workflowcheck/samples/gradle/README.md Removed references to composite build and unpublished releases
temporal-workflowcheck/samples/gradle-multi-project/project-app/build.gradle Updated workflowcheckDependency to use :all classifier
temporal-workflowcheck/samples/gradle-multi-project/README.md Removed references to composite build and unpublished releases

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 23 to 25
shadowJar {
relocate 'org.objectweb.asm', 'io.temporal.workflowcheck.shaded.org.objectweb.asm'
archiveClassifier = ''
}
Copy link

Copilot AI Feb 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The shadowJar is not configured to be published. While removing the archiveClassifier setting allows the shadowJar to default to the "all" classifier, the shadowJar artifact is not explicitly added to the Maven publication. Without adding the shadowJar to the publication configuration, it will be built but not published to Maven Central.

To publish the shadowJar as a classified artifact, you need to add publishing configuration that includes the shadowJar. For example:

publishing {
    publications {
        mavenJava(MavenPublication) {
            artifact shadowJar
        }
    }
}

Alternatively, you could add it in the afterEvaluate block of the root publishing.gradle for this specific module.

Copilot uses AI. Check for mistakes.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The claim is apparently incorrect for recent versions of Shadow. The plugin wires the shadow JAR into the Java component, so the existing from components.java directive already publishes it.

I confirmed in local publish tests that the -all jar is indeed getting exported.

@mjameswh mjameswh merged commit 9b61d44 into master Feb 20, 2026
17 checks passed
@mjameswh mjameswh deleted the workflowcheck-all-same-artifact-id branch February 20, 2026 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants