Fix initializer of instance members that reference identifiers declar…#6924
Merged
rileyajones merged 3 commits intotensorflow:masterfrom Oct 8, 2024
Merged
Fix initializer of instance members that reference identifiers declar…#6924rileyajones merged 3 commits intotensorflow:masterfrom
rileyajones merged 3 commits intotensorflow:masterfrom
Conversation
…ed in the constructor
When public class fields are enabled, such cases throw a TS error similar to this.
```
third_party/javascript/angular_components/src/cdk/platform/platform.ts:37:29 - error TS2729: Property '_platformId' is used before its initialization.
37 isBrowser: boolean = this._platformId
~~~~~~~~~~~
third_party/javascript/angular_components/src/cdk/platform/platform.ts:87:15
87 constructor(@Inject(PLATFORM_ID) private _platformId: Object) {}
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
'_platformId' is declared here.
```
This error is fixed by moving the initializer of such class members into the constructor.
This is a no-op change
See go/lsc-fix-properties-used-before-initialization
…ed in the constructor.
arcra
approved these changes
Oct 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for features / changes
See #6882 for an explanation as to why these changes are needed.
That PR was opened by an internal contributor who was having issues fixing the lint errors the encountered.