Fix CLI 'get' command treating empty-string values as missing#619
Open
bysiber wants to merge 1 commit intotheskumar:mainfrom
Open
Fix CLI 'get' command treating empty-string values as missing#619bysiber wants to merge 1 commit intotheskumar:mainfrom
bysiber wants to merge 1 commit intotheskumar:mainfrom
Conversation
The 'get' command uses 'if stored_value:' to check whether a key exists. This is a truthiness check that evaluates to False for empty strings, so 'KEY=' or 'KEY=""' causes the command to exit with code 1 as if the key doesn't exist. Use 'is not None' instead to correctly distinguish between a key set to an empty string and a key that is not present.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
getCLI command uses a truthiness check (if stored_value:) to determine whether a key was found. This fails for empty-string values, sincebool("") is False.For example, given a
.envfile with:Running
dotenv get DATABASE_PREFIXexits with code 1, as if the key doesn't exist — but it does exist, it's just set to an empty string.The fix changes the check from
if stored_value:toif stored_value is not None:, which correctly distinguishes between a key with an empty value and a key that is genuinely absent.