Skip to content

debug stream: fix a function name #10640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lyakh wants to merge 2 commits into
base: main
Choose a base branch
from
Open

debug stream: fix a function name #10640

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
98ba381
debug-stream: update to the latest Zephyr PR version
lyakh Mar 20, 2026
9e8ce6a
debug-slot: (cosmetic) reduce verbosity
lyakh Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions src/debug/debug_stream/debug_stream_slot.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,22 +147,20 @@ static int debug_stream_slot_init(void)
for (i = 0; i < CONFIG_MP_MAX_NUM_CPUS; i++) {
hdr->section_desc[i].core_id = i;
hdr->section_desc[i].buf_words =
(section_size - offsetof(struct debug_stream_circular_buf, data[0]))/
(section_size - offsetof(struct debug_stream_circular_buf, data[0])) /
sizeof(uint32_t);
hdr->section_desc[i].offset = offset;
LOG_INF("sections %u, size %u, offset %u",
i, section_size, offset);
LOG_DBG("sections %u, size %u, offset %u", i, section_size, offset);
Copy link

Copilot AI Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOG_DBG uses "%u" for section_size and offset, which are size_t. This can lead to incorrect output (and warnings/UB on platforms where size_t != unsigned int). Use %zu for size_t values (and cast i appropriately or use an unsigned type).

Suggested change
LOG_DBG("sections %u, size %u, offset %u", i, section_size, offset);
LOG_DBG("sections %d, size %zu, offset %zu", i, section_size, offset);

Copilot uses AI. Check for mistakes.
offset += section_size;
}
for (i = 0; i < CONFIG_MP_MAX_NUM_CPUS; i++) {
struct debug_stream_section_descriptor desc = { 0 };
struct debug_stream_circular_buf *buf =
debug_stream_get_circular_buffer(&desc, i);
struct debug_stream_circular_buf *buf = debug_stream_get_circular_buffer(&desc, i);

buf->next_seqno = 0;
buf->w_ptr = 0;
}
LOG_INF("Debug stream slot initialized");
LOG_DBG("Debug stream slot initialized");

return 0;
}
Expand Down
4 changes: 2 additions & 2 deletions src/debug/debug_stream/debug_stream_text_msg.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,8 +130,8 @@ static void ds_exception_dump(const char *format, va_list args)

static int init_exception_dump_hook(void)
{
set_exception_dump_hook(ds_exception_dump, ds_exception_drain);
LOG_INF("exception_dump_hook set");
arch_exception_set_dump_hook(ds_exception_dump, ds_exception_drain);
LOG_DBG("exception_dump_hook set");
return 0;
}

Expand Down
Loading