Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Caution Review failedPull request was closed or merged during review No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (9)
💤 Files with no reviewable changes (1)
🚧 Files skipped from review as they are similar to previous changes (6)
WalkthroughMulti-package release: version numbers and changelog entries updated for thirdweb, wagmi-adapter, nebula, and wagmi-demo; a changelog changeset file Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested labels
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
packages/thirdweb/package.json (1)
434-434: Addpackage.json#size-limitbudgets for this package.The version bump is fine, but this manifest still lacks a
size-limitbudget block. Please define/update it so bundle budgets are explicitly tracked in this package.As per coding guidelines "packages/thirdweb/package.json: Track bundle budgets via
package.json#size-limit".🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/thirdweb/package.json` at line 434, Add a size-limit budget block to this package's package.json (the top-level "package.json" for the package whose version is "5.119.1") under the "size-limit" key: define one or more budget entries targeting the package build outputs (for example the main bundles under "dist/" such as the ESM and CJS builds or any published entrypoints) with threshold sizes and optional reporters; update or add entries so CI will fail when the bundle exceeds the defined budgets. Locate the package.json file and add a "size-limit" object listing each bundle path and its budget (e.g., path and limit properties) so bundle size is explicitly tracked.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@packages/thirdweb/package.json`:
- Line 434: Add a size-limit budget block to this package's package.json (the
top-level "package.json" for the package whose version is "5.119.1") under the
"size-limit" key: define one or more budget entries targeting the package build
outputs (for example the main bundles under "dist/" such as the ESM and CJS
builds or any published entrypoints) with threshold sizes and optional
reporters; update or add entries so CI will fail when the bundle exceeds the
defined budgets. Locate the package.json file and add a "size-limit" object
listing each bundle path and its budget (e.g., path and limit properties) so
bundle size is explicitly tracked.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 0ceedcdc-c7e0-4741-a3ea-aec555393c09
📒 Files selected for processing (9)
.changeset/wallet-details-export-screen.mdapps/wagmi-demo/CHANGELOG.mdapps/wagmi-demo/package.jsonpackages/nebula/CHANGELOG.mdpackages/nebula/package.jsonpackages/thirdweb/CHANGELOG.mdpackages/thirdweb/package.jsonpackages/wagmi-adapter/CHANGELOG.mdpackages/wagmi-adapter/package.json
💤 Files with no reviewable changes (1)
- .changeset/wallet-details-export-screen.md
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8699 +/- ##
==========================================
- Coverage 52.73% 52.72% -0.01%
==========================================
Files 934 934
Lines 62968 62968
Branches 4138 4134 -4
==========================================
- Hits 33204 33199 -5
- Misses 29666 29671 +5
Partials 98 98
🚀 New features to boost your workflow:
|
size-limit report 📦
|
joaquim-verges
force-pushed
the
changeset-release/main
branch
from
f58dd7e to
f613bde
Compare
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| ## 0.2.208 | ||
|
|
There was a problem hiding this comment.
The changelog entry for version 0.2.208 is incomplete. It's missing the ### Patch Changes section and the actual change descriptions. All other packages in this PR have proper changelog entries with patch changes sections listing their updates.
Expected format:
## 0.2.208
### Patch Changes
- Updated dependencies [[`e13b9a7`](...)]:
- thirdweb@5.119.1This incomplete entry will make the changelog confusing for users trying to understand what changed in this version.
| ## 0.2.208 | |
| ## 0.2.208 | |
| ### Patch Changes | |
| - Updated dependencies [[`e13b9a7`](...)]: | |
| - thirdweb@5.119.1 | |
Spotted by Graphite
Is this helpful? React 👍 or 👎 to let us know.
2 participants
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@thirdweb-dev/nebula@0.2.111
Patch Changes
e13b9a7,da4a4a5]:thirdweb@5.119.1
Patch Changes
#8700
e13b9a7Thanks @0xFirekeeper! - Deprecate thethirdweb createCLI command#8698
da4a4a5Thanks @Yash094! - Addscreenprop touseWalletDetailsModalto allow opening the modal directly at a specific screen. Usescreen: "export"to open directly at the Export Private Key screen.@thirdweb-dev/wagmi-adapter@0.2.208
wagmi-inapp@0.0.53
Patch Changes
e13b9a7,da4a4a5]:PR-Codex overview
This PR focuses on updating version numbers across several packages and documenting changes in the changelogs. It introduces new features and dependency updates for the
thirdwebandwagmi-inappprojects.Detailed summary
versioninpackages/thirdweb/package.jsonfrom5.119.0to5.119.1versioninapps/wagmi-demo/package.jsonfrom0.0.52to0.0.53versioninpackages/nebula/package.jsonfrom0.2.110to0.2.111versioninpackages/wagmi-adapter/package.jsonfrom0.2.207to0.2.208thirdweb,wagmi-demo, andnebuladetailing new features and dependency updatesthirdweb createCLI commandscreenprop touseWalletDetailsModalfor direct modal accessSummary by CodeRabbit
New Features
Deprecations
Chores