Skip to content

send server wallet txn for native transfer fix#8701

Merged
graphite-app[bot] merged 1 commit intomainfrom
np/wallet_fix
Mar 6, 2026
Merged

send server wallet txn for native transfer fix#8701
graphite-app[bot] merged 1 commit intomainfrom
np/wallet_fix

Conversation

@nischitpra
Copy link
Contributor

@nischitpra nischitpra commented Mar 6, 2026

PR-Codex overview

This PR focuses on improving the handling of the token address in the SendProjectWalletModalContent function by normalizing it and ensuring consistency in the mutation process.

Detailed summary

  • Added normalization for tokenAddress to lowercase if it matches NATIVE_TOKEN_ADDRESS.
  • Updated the mutation function to use normalizedTokenAddress instead of values.tokenAddress.
  • Adjusted the spread operator for tokenAddress in the mutation payload.
  • Changed sendMutation.mutateAsync(values) to sendMutation.mutate(values).

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

  • Bug Fixes
    • Native token addresses are normalized so native tokens are recognized correctly for balance display and transfers.
    • Token decimal detection uses the normalized address for more accurate balance calculations.
    • Mutation payload now uses the normalized token address to ensure correct transfer payloads.
    • Send flow submission switched to a more reliable path to reduce submission issues and improve transfer dependability.

@nischitpra nischitpra requested review from a team as code owners March 6, 2026 13:40
@vercel
Copy link

vercel bot commented Mar 6, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
thirdweb-www Ready Ready Preview, Comment Mar 6, 2026 11:23pm
4 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs-v2 Skipped Skipped Mar 6, 2026 11:23pm
nebula Skipped Skipped Mar 6, 2026 11:23pm
thirdweb_playground Skipped Skipped Mar 6, 2026 11:23pm
wallet-ui Skipped Skipped Mar 6, 2026 11:23pm

@changeset-bot
Copy link

changeset-bot bot commented Mar 6, 2026

⚠️ No Changeset found

Latest commit: 8e9c51e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Mar 6, 2026
@nischitpra nischitpra changed the title send server wallet txn fix send server wallet txn for native transfer fix Mar 6, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 6, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 3a4b6fad-3d4a-49ea-88f5-ae052f3e3f4d

📥 Commits

Reviewing files that changed from the base of the PR and between 2613741 and 8e9c51e.

📒 Files selected for processing (1)
  • apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/components/project-wallet/project-wallet-details.tsx
🚧 Files skipped from review as they are similar to previous changes (1)
  • apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/components/project-wallet/project-wallet-details.tsx

Walkthrough

This change normalizes token addresses by treating the native token address (case-insensitive match to NATIVE_TOKEN_ADDRESS) as undefined, uses the normalized address for decimals lookup and send payloads, switches form submission from mutateAsync to mutate, and imports NATIVE_TOKEN_ADDRESS from thirdweb.

Changes

Cohort / File(s) Summary
Token Address Normalization & Submit Flow
apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/components/project-wallet/project-wallet-details.tsx
Normalize tokenAddress by comparing to NATIVE_TOKEN_ADDRESS (case-insensitive) and treating matches as undefined; use normalized address for readContract decimals lookup and in the send mutation payload; replace mutateAsync with mutate; add NATIVE_TOKEN_ADDRESS import.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description includes a detailed summary of changes but lacks required sections from the template: proper title format, issue tag, notes for reviewer, and testing instructions. Add the required template sections: format title as '[SDK/Dashboard/Portal] Feature/Fix: ...', include issue tag (TEAM-####), add reviewer notes, and specify how to test the changes.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title directly relates to the main change: fixing native token transfer handling by normalizing the token address.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch np/wallet_fix

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Mar 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 52.72%. Comparing base (01a20cb) to head (8e9c51e).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8701   +/-   ##
=======================================
  Coverage   52.72%   52.72%           
=======================================
  Files         934      934           
  Lines       62968    62968           
  Branches     4135     4135           
=======================================
  Hits        33199    33199           
  Misses      29671    29671           
  Partials       98       98           
Flag Coverage Δ
packages 52.72% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2026

size-limit report 📦

Path Size
@thirdweb-dev/nexus (esm) 105.66 KB (0%)
@thirdweb-dev/nexus (cjs) 319.47 KB (0%)

@vercel vercel bot temporarily deployed to Preview – docs-v2 March 6, 2026 14:06 Inactive
@vercel vercel bot temporarily deployed to Preview – nebula March 6, 2026 14:06 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui March 6, 2026 14:06 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground March 6, 2026 14:06 Inactive
@nischitpra nischitpra added the merge-queue Adds the pull request to Graphite's merge queue. label Mar 6, 2026 — with Graphite App
Copy link
Contributor Author

nischitpra commented Mar 6, 2026

Merge activity

<!-- start pr-codex -->

## PR-Codex overview
This PR focuses on normalizing the token address in the `SendProjectWalletModalContent` function to ensure consistency when interacting with the contract. It simplifies the handling of the native token address and adjusts how data is passed to the mutation.

### Detailed summary
- Added `normalizedTokenAddress` to handle token address normalization.
- Adjusted the condition to check `normalizedTokenAddress` instead of `values.tokenAddress`.
- Updated the contract call to use `normalizedTokenAddress`.
- Modified the mutation to include `normalizedTokenAddress` only if it exists.
- Changed the mutation call from `void sendMutation.mutateAsync(values)` to `sendMutation.mutate(values)`.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->

<!-- This is an auto-generated comment: release notes by coderabbit.ai -->
## Summary by CodeRabbit

* **Bug Fixes**
  * Improved native token handling in the project wallet so native tokens are correctly recognized for balance display and transfers.
  * More reliable token decimal detection to ensure accurate balance reads.
  * Fixed send flow to reduce submission issues and make fund transfers more dependable.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
@vercel vercel bot temporarily deployed to Preview – docs-v2 March 6, 2026 23:16 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui March 6, 2026 23:16 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground March 6, 2026 23:16 Inactive
@vercel vercel bot temporarily deployed to Preview – nebula March 6, 2026 23:16 Inactive
@graphite-app graphite-app bot merged commit 8e9c51e into main Mar 6, 2026
25 checks passed
@graphite-app graphite-app bot deleted the np/wallet_fix branch March 6, 2026 23:24
@vercel vercel bot temporarily deployed to Production – wallet-ui March 6, 2026 23:24 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 March 6, 2026 23:24 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground March 6, 2026 23:24 Inactive
@vercel vercel bot temporarily deployed to Production – nebula March 6, 2026 23:24 Inactive
@graphite-app graphite-app bot removed the merge-queue Adds the pull request to Graphite's merge queue. label Mar 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants