INT-3358: Remove @tinymce/miniature from dependency#76
Open
tiny-ben-tran wants to merge 23 commits intomainfrom
Open
INT-3358: Remove @tinymce/miniature from dependency#76tiny-ben-tran wants to merge 23 commits intomainfrom
tiny-ben-tran wants to merge 23 commits intomainfrom
Conversation
tiny-ben-tran
requested review from
a team,
MitchC1999,
TheSpyder,
shanmen-tiny and
soritaheng
and removed request for
a team
TheSpyder
approved these changes
Apr 1, 2026
src/test/ts/browser/DisabledTest.ts
Outdated
Comment on lines
+37
to
+38
| const pCreateEditor = | ||
| (attrs: Record<string, string> = {}, onSetup?: (editor: any) => void): Promise<{ el: EditorElement; editor: TinyMCEEditor }> => new Promise((resolve) => { |
Member
There was a problem hiding this comment.
I'm pretty sure miniature and/or mcagar have tools for this? Again, look to our premium tests for guidance (or I can help you dig that up if you need me to).
Contributor
Author
There was a problem hiding this comment.
I tried VersionHooks.bddSetupVersionFromElement and then realised that the wrapper creates its own Editor instance, making the hook.editor() instance an orphan.
I also updated the tests to use as many functions from miniature/mcagar as possible.
soritaheng
approved these changes
Apr 1, 2026
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
@tinymce/miniaturetodevDependencyso that this library can stay open sourceddisabledattribute.disabledattributets-nodecrashedLoadTestto BBD