[DO NOT REVIEW ] Append rules that match the glob in neal.json #24
Open
[DO NOT REVIEW ] Append rules that match the glob in neal.json #24
Conversation
tapthaker
force-pushed
the
change-rule-parsing
branch
from
d32d04d to
2930d4e
Compare
junyan-uber
reviewed
May 21, 2021
| // Make sure that there are only 3 errors emitted | ||
| // RUN: %not %neal %p | test $(wc -l) -eq 3 | ||
|
|
||
| // CHECK-L:apps/Application.swift:12: error: Force-casting can easily crash the app, therefore, not allowed. (NoForceCasting) |
There was a problem hiding this comment.
why do we expect only NoForceCasting is triggered for this file?
junyan-uber
reviewed
May 21, 2021
tapthaker
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Append rules that match the glob in neal.json instead of only pick the first one. This is a breaking change to neal and we could potentially decide to alter the behavior based on some flag.
Test plan: Integration tests, you can use make test to execute them