print_numeric: print mode in octal when the mode is too large#10208
print_numeric: print mode in octal when the mode is too large#10208ChrisDryden merged 1 commit intouutils:mainfrom
Conversation
|
GNU testsuite comparison: |
|
could you please add a test to make sure we don't regress in the future? thanks |
|
Heres an example test for this scenario for chmod that you can use in test_chmod: |
I had something similar, I have just been really busy. I am a university student. |
|
The test case results in this: |
CodSpeed Performance ReportMerging this PR will not alter performanceComparing Summary
Footnotes
|
|
So the OpenBSD CI is failing because 7777 is considered to be in invalid value: Which is This gets triggered because:
They are aware of this, see https://github.com/openbsd/src/blob/8105fbd98be243a48cc198cd0c33d8bce8095608/regress/lib/libc/sys/t_mkfifo.c#L225-L229 |
|
Are you still working on this? I think you just need to make that one line change in the test for BSD platforms and the PR is good to go. |
|
I am but I have been incredibly busy. I will try and make the change today.
…On February 2, 2026 2:38:51 PM UTC, Chris Dryden ***@***.***> wrote:
ChrisDryden left a comment (uutils/coreutils#10208)
Are you still working on this? I think you just need to make that one line change in the test for BSD platforms and the PR is good to go.
--
Reply to this email directly or view it on GitHub:
#10208 (comment)
You are receiving this because you authored the thread.
Message ID: ***@***.***>
|
This was caught when testing chmod inside of Redox OS. Previously, doing `chmod 10777 file` will cause an error stating that "mode is too large (4607 > 7777", which is both incorrect and contains a missing parenthesis. We now print the large octal value in terms of octal.
7913280 to
7aad46d
Compare
|
The change is ready. Please review when you have a chance. |
|
The OpenBSD test passes: https://github.com/uutils/coreutils/actions/runs/21632676699/job/62349346037#step:3:1366 |
ChrisDryden
left a comment
There was a problem hiding this comment.
Just waiting on the CI
…#10208) This was caught when testing chmod inside of Redox OS. Previously, doing `chmod 10777 file` will cause an error stating that "mode is too large (4607 > 7777", which is both incorrect and contains a missing parenthesis. We now print the large octal value in terms of octal. Co-authored-by: Connor-GH <connor-gh@outlook.com>
No description provided.