Skip to content

nice -n huge_num true#10213

Merged
sylvestre merged 1 commit intouutils:mainfrom
oech3:nice-huge
Jan 18, 2026
Merged

nice -n huge_num true#10213
sylvestre merged 1 commit intouutils:mainfrom
oech3:nice-huge

Conversation

@oech3
Copy link
Contributor

@oech3 oech3 commented Jan 13, 2026

Closes #10200

@oech3 oech3 changed the title Nice huge nice -n huge_num true Jan 13, 2026
@oech3 oech3 force-pushed the nice-huge branch 2 times, most recently from eec8ae2 to ae0c818 Compare January 13, 2026 10:50
@github-actions
Copy link

GNU testsuite comparison:

Skipping an intermittent issue tests/shuf/shuf-reservoir (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/sort/sort-stale-thread-mem (passes in this run but fails in the 'main' branch)

@oech3 oech3 force-pushed the nice-huge branch 2 times, most recently from 4ce1311 to 7a75ddd Compare January 13, 2026 15:42
@github-actions
Copy link

GNU testsuite comparison:

Skipping an intermittent issue tests/shuf/shuf-reservoir (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/sort/sort-stale-thread-mem (passes in this run but fails in the 'main' branch)

fn test_nice_huge() {
new_ucmd!()
.args(&[
"-n",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only positive overflow is tested. Should add a test for negative overflow (e.g., -999...9) to ensure both clamping directions work.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Negative is root test, would not work on the CI.
...
Oh yes. It should work with permission denied.

@oech3 oech3 force-pushed the nice-huge branch 2 times, most recently from fae9d13 to 0166306 Compare January 14, 2026 00:47
@github-actions
Copy link

GNU testsuite comparison:

Skipping an intermittent issue tests/tty/tty-eof (passes in this run but fails in the 'main' branch)

@oech3 oech3 force-pushed the nice-huge branch 3 times, most recently from d7cd76f to 07d3f52 Compare January 17, 2026 16:07
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think moving it into a function could help with readability

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this operation duplicated at somethere?

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 17, 2026

Merging this PR will degrade performance by 52.55%

❌ 34 regressed benchmarks
✅ 248 untouched benchmarks
⏩ 38 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Memory sort_general_numeric[200000] 23.6 MB 43.2 MB -45.37%
Memory sort_numeric_utf8_locale 4.2 MB 8.8 MB -52.55%
Memory sort_mixed_c_locale 2.6 MB 3 MB -12.17%
Memory sort_long_line[160000] 716.7 KB 981.4 KB -26.98%
Memory sort_german_c_locale 3.6 MB 5.3 MB -33.11%
Memory sort_ascii_utf8_locale 5.6 MB 6.2 MB -9.9%
Memory sort_mixed_utf8_locale 2.6 MB 3.5 MB -25.41%
Memory sort_reverse_locale[500000] 21.6 MB 27.5 MB -21.64%
Memory sort_numeric[500000] 48.7 MB 79.2 MB -38.49%
Memory sort_unique_utf8_locale 3.8 MB 4.6 MB -18.99%
Memory sort_key_field[500000] 32.8 MB 51.8 MB -36.61%
Memory sort_german_de_locale 3.6 MB 5.3 MB -33.11%
Memory sort_ascii_c_locale 6.1 MB 8.3 MB -26.89%
Memory sort_dictionary_order[500000] 29.7 MB 42 MB -29.38%
Memory sort_unique_locale[500000] 36.9 MB 39.8 MB -7.07%
Memory sort_reverse_utf8_locale 2.6 MB 3 MB -11.96%
Memory sort_mixed_data[500000] 25.8 MB 27.1 MB -4.8%
Memory sort_accented_data[500000] 25.5 MB 28.3 MB -9.94%
Memory sort_ascii_only[500000] 25.5 MB 28.3 MB -9.9%
Memory sort_case_insensitive[500000] 16.3 MB 16.9 MB -3.34%
... ... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.


Comparing oech3:nice-huge (5d9567a) with main (4bfbbdd)2

Open in CodSpeed

Footnotes

  1. 38 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on main (b3ad96f) during the generation of this report, so 4bfbbdd was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@github-actions
Copy link

GNU testsuite comparison:

GNU test failed: tests/tail/follow-name. tests/tail/follow-name is passing on 'main'. Maybe you have to rebase?

@oech3 oech3 force-pushed the nice-huge branch 3 times, most recently from 27be172 to b114e0a Compare January 17, 2026 20:49
@github-actions
Copy link

GNU testsuite comparison:

Congrats! The gnu test tests/basenc/bounded-memory is now passing!

@github-actions
Copy link

GNU testsuite comparison:

Congrats! The gnu test tests/basenc/bounded-memory is now passing!

@oech3 oech3 force-pushed the nice-huge branch 2 times, most recently from 858f4f0 to 7d3c2ad Compare January 17, 2026 21:51
@github-actions
Copy link

GNU testsuite comparison:

Congrats! The gnu test tests/basenc/bounded-memory is now passing!

@oech3 oech3 force-pushed the nice-huge branch 3 times, most recently from 917605c to 34c2172 Compare January 18, 2026 04:36
@github-actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/shuf/shuf-reservoir (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/sort/sort-stale-thread-mem (fails in this run but passes in the 'main' branch)

@github-actions
Copy link

GNU testsuite comparison:

Skipping an intermittent issue tests/tty/tty-eof (passes in this run but fails in the 'main' branch)

@github-actions
Copy link

GNU testsuite comparison:

Skipping an intermittent issue tests/tty/tty-eof (passes in this run but fails in the 'main' branch)

@sylvestre sylvestre merged commit ca13e33 into uutils:main Jan 18, 2026
157 checks passed
@oech3 oech3 deleted the nice-huge branch January 18, 2026 15:04
mattsu2020 pushed a commit to mattsu2020/coreutils that referenced this pull request Jan 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

nice: nice -n 2147483648 true fails

2 participants

Comments