chmod/chown: symlink cycles detection#11805
Open
nikolalukovic wants to merge 2 commits intouutils:mainfrom
Open
chmod/chown: symlink cycles detection#11805nikolalukovic wants to merge 2 commits intouutils:mainfrom
nikolalukovic wants to merge 2 commits intouutils:mainfrom
Conversation
|
GNU testsuite comparison: |
nikolalukovic
force-pushed
the
fix/11614
branch
3 times, most recently
from
e17c9e9 to
1990e91
Compare
Contributor
Author
|
Failing tests are unrelated to these changes. |
nikolalukovic
force-pushed
the
fix/11614
branch
from
1990e91 to
168aac1
Compare
nikolalukovic
force-pushed
the
fix/11614
branch
from
168aac1 to
16ecfdd
Compare
Contributor
Author
|
@sylvestre can you please take a look? |
blakshya
reviewed
Apr 22, 2026
| } | ||
| if self.recursive { | ||
| r = self.walk_dir_with_context(file, true).and(r); | ||
| let mut ancestors = HashSet::new(); |
There was a problem hiding this comment.
Hi,
I'm new here and found this PR when looking at how first issues are handled. Please correct me if i'm missing something.
Looking at GNU implementation, they push down the onus of cycle detection to a generic read function and only reference a cycle detection flag. That looks modular enough to not pass a new hash set everytime?
How would this be extended extended to other places when required?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempts to fix: #11614