Skip to content

tee: merge logic of flush into write#11893

Merged
sylvestre merged 3 commits intouutils:mainfrom
xtqqczze:tee-retain-with
Apr 20, 2026
Merged

tee: merge logic of flush into write#11893
sylvestre merged 3 commits intouutils:mainfrom
xtqqczze:tee-retain-with

Conversation

@xtqqczze
Copy link
Copy Markdown
Contributor

@xtqqczze xtqqczze commented Apr 18, 2026

Closes #11914

@xtqqczze xtqqczze marked this pull request as ready for review April 18, 2026 20:09
Comment thread src/uu/tee/src/tee.rs Outdated
Comment thread src/uu/tee/src/tee.rs
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 19, 2026

GNU testsuite comparison:

Skip an intermittent issue tests/date/resolution (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)

@oech3
Copy link
Copy Markdown
Contributor

oech3 commented Apr 19, 2026

Since tee.rs always call flush() after write_all(), we can just merge those functions.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Apr 20, 2026

Merging this PR will not alter performance

✅ 309 untouched benchmarks
⏩ 46 skipped benchmarks1


Comparing xtqqczze:tee-retain-with (c825f07) with main (34fd4be)

Open in CodSpeed

Footnotes

  1. 46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@xtqqczze xtqqczze changed the title refactor(tee): introduce retain_with method for MultiWriter tee: merge logic of flush into write Apr 20, 2026
Comment thread src/uu/tee/src/tee.rs
xtqqczze and others added 2 commits April 20, 2026 17:18
Co-authored-by: oech3 <79379754+oech3@users.noreply.github.com>
@sylvestre sylvestre merged commit bd76e84 into uutils:main Apr 20, 2026
169 checks passed
@xtqqczze xtqqczze deleted the tee-retain-with branch April 20, 2026 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants