Skip to content

du: Allow command-line argument that appears more than once#11897

Merged
sylvestre merged 16 commits intouutils:mainfrom
ajanicij:ajanicij/du-accept-repeated-argument
Apr 20, 2026
Merged

du: Allow command-line argument that appears more than once#11897
sylvestre merged 16 commits intouutils:mainfrom
ajanicij:ajanicij/du-accept-repeated-argument

Conversation

@ajanicij
Copy link
Copy Markdown
Contributor

@ajanicij ajanicij commented Apr 19, 2026

Fix for 1173: du: error: the argument '--human-readable' cannot be used multiple times (but works in GNU).

  • For du command, accept a repeated command-line argument wherever it makes sense.

@ajanicij
Copy link
Copy Markdown
Contributor Author

I discovered from the CI/CD test that NO_DEREFERENCE was correct to begin with. Undid my "fix".

@sylvestre
Copy link
Copy Markdown
Contributor

please add a test that verify all these changes to make sure we don't regress in the future

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 19, 2026

GNU testsuite comparison:

Skip an intermittent issue tests/date/date-locale-hour (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/rm/isatty (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/cut/bounded-memory (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)

@ajanicij ajanicij marked this pull request as ready for review April 20, 2026 05:25
Comment thread tests/by-util/test_du.rs Outdated
Comment thread tests/by-util/test_du.rs
Comment thread tests/by-util/test_du.rs Outdated
Comment thread tests/by-util/test_du.rs
Comment thread tests/by-util/test_du.rs
Comment thread tests/by-util/test_du.rs
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Apr 20, 2026

Merging this PR will improve performance by 3.02%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 1 improved benchmark
✅ 308 untouched benchmarks
⏩ 46 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation du_max_depth_balanced_tree[(6, 4, 10)] 25.8 ms 25 ms +3.02%

Comparing ajanicij:ajanicij/du-accept-repeated-argument (d21d3b6) with main (34fd4be)

Open in CodSpeed

Footnotes

  1. 46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@sylvestre sylvestre merged commit 6133ef5 into uutils:main Apr 20, 2026
165 of 166 checks passed
@sylvestre
Copy link
Copy Markdown
Contributor

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants