feat(isDate): add delimiter-less date formats#2659
feat(isDate): add delimiter-less date formats#2659xseman wants to merge 5 commits intovalidatorjs:masterfrom
Conversation
Add test cases for `isDate` validator to handle various delimiter-less date formats including `YYYYMMDD`, `YYMMDD`, `MMDDYYYY`, and `DDMMYYYY`.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2659 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 114 114
Lines 2572 2601 +29
Branches 651 655 +4
=========================================
+ Hits 2572 2601 +29 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
The |
|
Thanks for opening this PR! I think we should only accept these behind a non-default option, to not cause a breaking change |
|
Thanks for the feedback, @WikiRik. What do you think about adding an opt-in for delimiter-less format support to avoid breaking changes? const default_date_options = {
format: 'YYYY/MM/DD',
delimiters: ['/', '-'],
strictMode: false,
allowDelimiterless: false, // <----
};// Existing behavior unchanged
validator.isDate('20020715'); // false
// Opt-in to new feature
validator.isDate('20020715', {
format: 'YYYYMMDD',
allowDelimiterless: true
}); // true |
|
@xseman yup, that's exactly what I had in mind! |
|
Thanks for the quick feedback, last changes should do |
|
@WikiRik let me know if there's anything else you want me to change or fix before it's ready |
Add test cases for
isDatevalidator to handle various delimiter-less date formats includingYYYYMMDD,YYMMDD,.MMDDYYYYandDDMMYYYYChecklist