Dont log internaldial side channel stuff#385
Open
elijahcarrel wants to merge 3 commits intovanadium:mainfrom
Open
Dont log internaldial side channel stuff#385elijahcarrel wants to merge 3 commits intovanadium:mainfrom
elijahcarrel wants to merge 3 commits intovanadium:mainfrom
Conversation
cosnicolaou
approved these changes
Apr 15, 2023
Contributor
|
Moving it down a log level is fine. However, GRAIL is running a branch and not from head, so you'll need to make the change there too if you want to pick it up at GRAIL. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure what the "internalDial: side channel…" info statement really indicates, but I have been told at GRAIL to ignore it. It shows up in stdout on nearly every
vrpcornamespacecommand I performed. Can I suppress it down one log level so that this (hopefully) no longer shows up?Thanks for your consideration!