Skip to content

feat: add tab:close keyboard shortcut #8116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nKOxxx wants to merge 1 commit into
base: canary
Choose a base branch
from
+11 −0
Open

feat: add tab:close keyboard shortcut #8116

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions app/commands.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,9 @@ const commands: Record<string, (focusedWindow?: BrowserWindow) => void> = {
'pane:close': (focusedWindow) => {
focusedWindow?.rpc.emit('termgroup close req');
},
'tab:close': (focusedWindow) => {
focusedWindow?.rpc.emit('tab close req');
},
'window:preferences': () => {
void openConfig();
},
Expand Down
1 change: 1 addition & 0 deletions app/keymaps/darwin.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
"command+alt+left",
"ctrl+shift+tab"
],
"tab:close": "command+w",
"tab:jump:prefix": "command",
"pane:next": "command+]",
"pane:prev": "command+[",
Expand Down
1 change: 1 addition & 0 deletions app/keymaps/linux.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
"ctrl+alt+left",
"ctrl+shift+tab"
],
"tab:close": "ctrl+w",
"tab:jump:prefix": "ctrl",
"pane:next": "ctrl+pageup",
"pane:prev": "ctrl+pagedown",
Expand Down
1 change: 1 addition & 0 deletions app/keymaps/win32.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
"tab:prev": [
"ctrl+shift+tab"
],
"tab:close": "ctrl+w",
"tab:jump:prefix": "ctrl",
"pane:next": "ctrl+pageup",
"pane:prev": "ctrl+pagedown",
Expand Down
5 changes: 5 additions & 0 deletions lib/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import type {configOptions} from '../typings/config';
import {loadConfig, reloadConfig} from './actions/config';
import init from './actions/index';
import {addNotificationMessage} from './actions/notifications';
import * as headerActions from './actions/header';
import * as sessionActions from './actions/sessions';
import * as termGroupActions from './actions/term-groups';
import * as uiActions from './actions/ui';
Expand Down Expand Up @@ -97,6 +98,10 @@ rpc.on('termgroup close req', () => {
store_.dispatch(termGroupActions.exitActiveTermGroup());
});

rpc.on('tab close req', () => {
store_.dispatch(headerActions.closeTab(store_.getState().sessions.activeUid));
});

rpc.on('session clear req', () => {
store_.dispatch(sessionActions.clearActiveSession());
});
Expand Down