fix: onMouseEnter & onMouseLeave trigger between joined layers (#1671)#2126
Open
Jungzl wants to merge 3 commits intovisgl:masterfrom
Open
fix: onMouseEnter & onMouseLeave trigger between joined layers (#1671)#2126Jungzl wants to merge 3 commits intovisgl:masterfrom
onMouseEnter & onMouseLeave trigger between joined layers (#1671)#2126Jungzl wants to merge 3 commits intovisgl:masterfrom
Conversation
Jungzl
force-pushed
the
fix-enter-leave
branch
from
a9772e6 to
1d26d3f
Compare
src/mapbox/mapbox.ts
Outdated
| return 0; | ||
| } | ||
| return features.filter( | ||
| (feature, index) => features.findIndex(f => f.layer.id === feature.layer.id) === index |
Collaborator
There was a problem hiding this comment.
This is very inefficient. Use new Set(ids).size
| const hoveringLayersCount = this._uniqueLayersCount(features); | ||
|
|
||
| if (!isHovering && wasHovering) { | ||
| if (hoveringLayersCount < hoveredLayersCount) { |
Collaborator
There was a problem hiding this comment.
Is this correct, though? What if the layer count is the same but one layer is replaced by another?
Contributor
Author
There was a problem hiding this comment.
don't know if it's ok to call pointEvents twice in one callback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #1671