Conversation
|
dupllicate #58659 |
|
@Nizarjh I apologize for the duplicate pr. |
u can use my template and patches for your own) |
58e12fe to
abf6b69
Compare
|
u need also change binary name from zed to smth with patch. u can look how i made this in my pr. But my pacth is not actual to new version. so do your own for this version of zed |
@Nizarjh I don't need to use that patch. I'm renaming the executable at do_install stage. There's also an additional check in the check build CI/CD that ensures no name conflicts occur in the executables(which successfully passes) |
oh i see. Sorry :) |
srcpkgs/zeditor/template
Outdated
| pkgname=zeditor | ||
| version=0.231.1 | ||
| revision=1 | ||
| archs="x86_64 aarch64" |
There was a problem hiding this comment.
| archs="x86_64 aarch64" | |
| archs="x86_64* aarch64*" |
There was a problem hiding this comment.
Didn't compile successfully on musl versions locally
There was a problem hiding this comment.
Then that is a merge blocker, there is no reason it shouldn't work with musl.
There was a problem hiding this comment.
Because of dependencies not existing in one of the musl version. For details, I'll let you know when I get home
There was a problem hiding this comment.
x86_64-linux-musl:
ERROR: Could not find package 'cross-x86_64-linux-musl'
=> ERROR: cross-x86_64-linux-musl-0.37_5: cannot be built, it's currently broken; see the build log:
=> ERROR: cross-x86_64-linux-musl-0.37_5: Can't build crosstoolchain to itself
aarch64-musl:
error: failed to run custom build command for `prost-build v0.9.0`
Caused by:
process didn't exit successfully: `/builddir/zed-0.231.1/target/release/build/prost-build-b23121bcf79afb3f/build-script-build` (exit status: 101)
--- stderr
thread 'main' (12773) panicked at /host/cargo/registry/src/index.crates.io-1949cf8c6b5b557f/prost-build-0.9.0/build.rs:105:10:
Failed to find the protoc binary. The PROTOC environment variable is not set, there is no bundled protoc for this platform, and protoc is not in the PATH
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
ec019c1 to
9640597
Compare
|
im sorry for closing and opening the pr. renaming the branch messed it up |
Testing the changes
New package
Local build testing