Handle C23 const-preserving libc macros #672
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since [0] some standard library functions (e. g. `memchr`) are const preserving in C23-mode, i. e. return `const char *` instead of `char *` if `const char *` was passed. gcc-15 uses C23 by default and currently build with gcc-15 & glibc-2.43 fails. [0] https://sourceware.org/git/?p=glibc.git;a=commit;h=cd748a63ab1a7ae846175c532a3daab341c62690
Member
|
xbps is written as C99, wouldn't it make more sense to add |
Contributor
Author
|
IMHO wouldn't hurt to build cleanly in C23-mode, but can change cflags instead if |
Member
|
The casts are wrong, instead the function arguments should not be made const. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since [0] some standard library functions (e. g.
memchr) are const preserving in C23-mode, i. e. returnconst char *instead ofchar *ifconst char *was passed.gcc-15 uses C23 by default and currently build with gcc-15 & glibc-2.43 fails.
[0] https://sourceware.org/git/?p=glibc.git;a=commit;h=cd748a63ab1a7ae846175c532a3daab341c62690