fix: show node version fallback in vp --version#1032
Merged
Conversation
✅ Deploy Preview for viteplus-preview canceled.
|
TheAlexLichter
force-pushed
the
fix/node-in-vp-version
branch
2 times, most recently
from
6f47cb6 to
db981c5
Compare
TheAlexLichter
commented
Mar 18, 2026
packages/cli/snap-tests-global/command-staged-with-config/snap.txt
Outdated
Show resolved
Hide resolved
Member
|
@codex review |
Member
|
@TheAlexLichter Thanks! 😄 |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 468b94d131
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Member
|
@TheAlexLichter should resolve conflicts then rerun the snap tests. |
TheAlexLichter
force-pushed
the
fix/node-in-vp-version
branch
from
d951b87 to
b7010ae
Compare
TheAlexLichter
force-pushed
the
fix/node-in-vp-version
branch
from
b7010ae to
d951b87
Compare
TheAlexLichter
force-pushed
the
fix/node-in-vp-version
branch
from
d951b87 to
dcadf1f
Compare
fengmk2
reviewed
Mar 19, 2026
packages/cli/snap-tests-global/command-staged-with-config/snap.txt
Outdated
Show resolved
Hide resolved
fengmk2
approved these changes
Mar 19, 2026
Member
fengmk2
left a comment
fengmk2
left a comment
There was a problem hiding this comment.
@TheAlexLichter I will fix the flaky snap test before I mergeit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1020