fix(cli): warn when object-form manualChunks is detected#1046
Open
kazupon wants to merge 3 commits intovoidzero-dev:mainfrom
Open
fix(cli): warn when object-form manualChunks is detected#1046kazupon wants to merge 3 commits intovoidzero-dev:mainfrom
kazupon wants to merge 3 commits intovoidzero-dev:mainfrom
Conversation
✅ Deploy Preview for viteplus-preview canceled.
|
kazupon
commented
Mar 19, 2026
| try { | ||
| const { resolveConfig } = await import('../index.js'); | ||
| const { checkManualChunksCompat } = await import('./compat.js'); | ||
| const config = await resolveConfig({ root: rootDir, logLevel: 'silent' }, 'build'); |
Collaborator
Author
There was a problem hiding this comment.
Hmm, logLevel: 'silent' not propagated to Rolldown during config bundling
When calling resolveConfig({ logLevel: 'silent' }), the logLevel is passed to loadConfigFromFile but is not forwarded to bundleConfigFile → rolldown(). This means Rolldown still prints UNRESOLVED_IMPORT warnings to stderr even when silent mode is requested, in the migration.
Member
There was a problem hiding this comment.
Should we create an issue for rolldown as a follow-up? This won't block our current fix here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolve #900