fix(cli): ignore OSC colors queries in devcontainer or docker#954
Closed
Emiyaaaaa wants to merge 3 commits intovoidzero-dev:mainfrom
Closed
fix(cli): ignore OSC colors queries in devcontainer or docker#954Emiyaaaaa wants to merge 3 commits intovoidzero-dev:mainfrom
Emiyaaaaa wants to merge 3 commits intovoidzero-dev:mainfrom
Conversation
✅ Deploy Preview for viteplus-preview canceled.
|
Emiyaaaaa
changed the title
Emiyaaaaa
changed the title
fengmk2
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR disables terminal OSC color querying when running inside a Docker container (detected via /.dockerenv) to avoid unreliable/late responses that can leak as visible text after cooked mode is restored.
Changes:
- Add an early-return guard in
query_terminal_colorswhen/.dockerenvexists.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
Will provide more complete support in #986 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixed #838